From: Petr Štetiar <ynezz@true.cz>
Date: Thu, 5 Mar 2020 08:33:52 +0000 (+0100)
Subject: rpcd: fix respawn settings
X-Git-Tag: v21.02.0-rc1~3453
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=52e6fb13692986c76fd32159fb9fc82d712a5c3f;p=openwrt%2Fstaging%2Fhauke.git

rpcd: fix respawn settings

Commit 432ec292ccc8 ("rpcd: add respawn param") has introduced infinite
restarting of the service which could be reached over network. This is
not recommended security practice as it might give potential adversary
infinite number of tries in case there might be some issue in the rpcd
or its surrounding stack.

So lets remove the currently bogus `respawn_retry` variable (it wasn't
possible to override it anyway), reverting to the previous default max.
of 5 service restarts which could be now overriden via system's UCI
settings if desired.

Cc: Jo-Philip Wich <jow@mein.io>
Cc: Florian Eckert <fe@dev.tdt.de>
Cc: Hauke Mehrtens <hauke@hauke-m.de>
Fixes: 432ec292ccc8 ("rpcd: add respawn param")
Signed-off-by: Petr Štetiar <ynezz@true.cz>
---

diff --git a/package/system/rpcd/files/rpcd.init b/package/system/rpcd/files/rpcd.init
index 3e9ea5bbf3..f75d0e0f0e 100755
--- a/package/system/rpcd/files/rpcd.init
+++ b/package/system/rpcd/files/rpcd.init
@@ -12,7 +12,7 @@ start_service() {
 
 	procd_open_instance
 	procd_set_param command "$PROG" ${socket:+-s "$socket"} ${timeout:+-t "$timeout"}
-	procd_set_param respawn ${respawn_retry:-0}
+	procd_set_param respawn
 	procd_close_instance
 }