From: Axel Lin Date: Fri, 10 Dec 2010 09:34:26 +0000 (+0800) Subject: ALSA: aoa: Remove wrong i2c_set_clientdata in onyx_i2c_remove() X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=5144c534d16529bc469396211131e8935589f833;p=openwrt%2Fstaging%2Fblogic.git ALSA: aoa: Remove wrong i2c_set_clientdata in onyx_i2c_remove() It does not make sense to set clientdata to onyx in onyx_i2c_remove() as we are going to kfree onyx. What we really want here is i2c_set_clientdata(client, NULL); Since the i2c core will take care of it now, so this patch just removes it. Signed-off-by: Axel Lin Signed-off-by: Takashi Iwai --- diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c index 91852e49910e..3687a6cc9881 100644 --- a/sound/aoa/codecs/onyx.c +++ b/sound/aoa/codecs/onyx.c @@ -1114,7 +1114,6 @@ static int onyx_i2c_remove(struct i2c_client *client) of_node_put(onyx->codec.node); if (onyx->codec_info) kfree(onyx->codec_info); - i2c_set_clientdata(client, onyx); kfree(onyx); return 0; }