From: Jesper Juhl <jj@chaosbits.net>
Date: Mon, 9 Apr 2012 20:52:10 +0000 (+0200)
Subject: ALSA: riptide: remove redundant NULL test before release_firmware()
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=507230c9997ef47147818508108b97b3e189826f;p=openwrt%2Fstaging%2Fblogic.git

ALSA: riptide: remove redundant NULL test before release_firmware()

release_firmware() deals gracefully with NULL pointers, no need to check first.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
index 0481d94aac9b..cbeb3f77350c 100644
--- a/sound/pci/riptide/riptide.c
+++ b/sound/pci/riptide/riptide.c
@@ -1837,8 +1837,7 @@ static int snd_riptide_free(struct snd_riptide *chip)
 	}
 	if (chip->irq >= 0)
 		free_irq(chip->irq, chip);
-	if (chip->fw_entry)
-		release_firmware(chip->fw_entry);
+	release_firmware(chip->fw_entry);
 	release_and_free_resource(chip->res_port);
 	kfree(chip);
 	return 0;