From: Paul Spooren Date: Sun, 25 Jul 2021 22:36:19 +0000 (+0200) Subject: luci-app-attendedsysupgrade: fix empty array condition X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=505b671c210de07977321067c49a89570a33ebfa;p=project%2Fluci.git luci-app-attendedsysupgrade: fix empty array condition In JavaScript (other than in Python) an empty array is considered `true` within if statements. Fix this by checking for the array length rather than its existence. This fixes the issue of an empty dropdown menu in case the user is running the latest release. Signed-off-by: Paul Spooren --- diff --git a/applications/luci-app-attendedsysupgrade/htdocs/luci-static/resources/view/attendedsysupgrade/overview.js b/applications/luci-app-attendedsysupgrade/htdocs/luci-static/resources/view/attendedsysupgrade/overview.js index f6d31a35be..3ee99684da 100644 --- a/applications/luci-app-attendedsysupgrade/htdocs/luci-static/resources/view/attendedsysupgrade/overview.js +++ b/applications/luci-app-attendedsysupgrade/htdocs/luci-static/resources/view/attendedsysupgrade/overview.js @@ -255,7 +255,7 @@ function check_sysupgrade(server_url, current_version, target, board_name, packa } } } - if (candidates) { + if (candidates.length) { var m, s, o; var mapdata = {