From: Jia-Ju Bai Date: Wed, 11 Apr 2018 07:33:06 +0000 (+0800) Subject: infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_l2param_change X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=4e56569cee1505846b3dcb15fbf400f6a7e9f015;p=openwrt%2Fstaging%2Fblogic.git infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_l2param_change i40iw_l2param_change() is never called in atomic context. i40iw_make_listen_node() is only set as ".l2_param_change" in struct i40e_client_ops, and this function pointer is not called in atomic context. Despite never getting called from atomic context, i40iw_l2param_change() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai Acked-by: Shiraz Saleem Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/hw/i40iw/i40iw_main.c b/drivers/infiniband/hw/i40iw/i40iw_main.c index 9cd0d3ef9057..a220794dcdb0 100644 --- a/drivers/infiniband/hw/i40iw/i40iw_main.c +++ b/drivers/infiniband/hw/i40iw/i40iw_main.c @@ -1758,7 +1758,7 @@ static void i40iw_l2param_change(struct i40e_info *ldev, struct i40e_client *cli return; - work = kzalloc(sizeof(*work), GFP_ATOMIC); + work = kzalloc(sizeof(*work), GFP_KERNEL); if (!work) return;