From: Wei Yongjun Date: Tue, 16 Oct 2018 02:35:16 +0000 (+0000) Subject: ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources() X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=4ab7fd955e471a71908d4970017c52b3ef6e47a2;p=openwrt%2Fstaging%2Fblogic.git ath10k: fix copy-paste error in ath10k_qmi_setup_msa_resources() The return value from devm_memremap() is not checked correctly. The test is done against a wrong variable. This patch fix it. Fixes: ba94c753ccb4 ("ath10k: add QMI message handshake for wcn3990 client") Signed-off-by: Wei Yongjun Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/ath10k/qmi.c b/drivers/net/wireless/ath/ath10k/qmi.c index 56cb1831dcdf..c2cbb415971e 100644 --- a/drivers/net/wireless/ath/ath10k/qmi.c +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -931,7 +931,7 @@ static int ath10k_qmi_setup_msa_resources(struct ath10k_qmi *qmi, u32 msa_size) qmi->msa_mem_size = resource_size(&r); qmi->msa_va = devm_memremap(dev, qmi->msa_pa, qmi->msa_mem_size, MEMREMAP_WT); - if (!qmi->msa_pa) { + if (!qmi->msa_va) { dev_err(dev, "failed to map memory region: %pa\n", &r.start); return -EBUSY; }