From: Roel Kluin <roel.kluin@gmail.com>
Date: Tue, 8 Dec 2009 22:08:59 +0000 (-0800)
Subject: [SCSI] u14-34f: fix buffer overflow
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=4a02462af1f4c3498e6a330ffd5c063118309b31;p=openwrt%2Fstaging%2Fblogic.git

[SCSI] u14-34f: fix buffer overflow

This allows i == MAX_INT_PARAM, which is out of range for ints[]

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---

diff --git a/drivers/scsi/u14-34f.c b/drivers/scsi/u14-34f.c
index 54023d41fd15..26e8e0e6b8dd 100644
--- a/drivers/scsi/u14-34f.c
+++ b/drivers/scsi/u14-34f.c
@@ -1070,7 +1070,7 @@ static int option_setup(char *str) {
    char *cur = str;
    int i = 1;
 
-   while (cur && isdigit(*cur) && i <= MAX_INT_PARAM) {
+   while (cur && isdigit(*cur) && i < MAX_INT_PARAM) {
       ints[i++] = simple_strtoul(cur, NULL, 0);
 
       if ((cur = strchr(cur, ',')) != NULL) cur++;