From: Gilad Ben-Yossef Date: Sun, 3 Dec 2017 13:58:19 +0000 (+0000) Subject: staging: ccree: NULLify backup_info when unused X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=46df8824982e4fb0198776078d4a8c3e2d531464;p=openwrt%2Fstaging%2Fblogic.git staging: ccree: NULLify backup_info when unused backup_info field is only allocated for decrypt code path. The field was not nullified when not used causing a kfree in an error handling path to attempt to free random addresses as uncovered in stress testing. Fixes: 737aed947f9b ("staging: ccree: save ciphertext for CTS IV") Cc: stable@vger.kernel.org Signed-off-by: Gilad Ben-Yossef Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c index 901961553e5f..7b484f111d12 100644 --- a/drivers/staging/ccree/ssi_cipher.c +++ b/drivers/staging/ccree/ssi_cipher.c @@ -907,6 +907,7 @@ static int ssi_ablkcipher_encrypt(struct ablkcipher_request *req) unsigned int ivsize = crypto_ablkcipher_ivsize(ablk_tfm); req_ctx->is_giv = false; + req_ctx->backup_info = NULL; return ssi_blkcipher_process(tfm, req_ctx, req->dst, req->src, req->nbytes, req->info, ivsize,