From: Roland Barenbrug Date: Wed, 29 Jun 2022 11:09:25 +0000 (+0200) Subject: ltq-vdsl-app: Fix counter overflow resulting in negative values X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=456b9029d764e69f390ee26bca24883b12eb83c2;p=openwrt%2Fstaging%2Fdedeckeh.git ltq-vdsl-app: Fix counter overflow resulting in negative values The re-transmit counters can overflow the 32 bit representation resulting in negative values being displayed. Background being that the numbers are treated at some point as signed INT rather than unsigned INT. Change the counters from 32 bit to 64 bit, should provide sufficient room to avoid any overflow. Not the nicest solution but it works Fixes: #10077 Signed-off-by: Roland Barenbrug Acked-by: Martin Blumenstingl --- diff --git a/package/network/config/ltq-vdsl-app/src/src/dsl_cpe_ubus.c b/package/network/config/ltq-vdsl-app/src/src/dsl_cpe_ubus.c index 93eecaf71d..61ac7708ba 100644 --- a/package/network/config/ltq-vdsl-app/src/src/dsl_cpe_ubus.c +++ b/package/network/config/ltq-vdsl-app/src/src/dsl_cpe_ubus.c @@ -146,7 +146,7 @@ static inline void m_bool(const char *id, bool value) { } static inline void m_u32(const char *id, uint32_t value) { - blobmsg_add_u32(&b, id, value); + blobmsg_add_u64(&b, id, value); } static inline void m_str(const char *id, const char *value) {