From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 10 Dec 2015 22:44:34 +0000 (+0100)
Subject: ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=4188146566a9f1d57dfce77fd9457f7304b69dfa;p=openwrt%2Fstaging%2Fblogic.git

ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---

diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 199a94a9c8bc..b1cd865ade2e 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
 		urb = usb_get_from_anchor(&atusb->idle_urbs);
 		if (!urb)
 			break;
-		if (urb->context)
-			kfree_skb(urb->context);
+		kfree_skb(urb->context);
 		usb_free_urb(urb);
 	}
 }