From: Masahiro Yamada Date: Sun, 25 Dec 2016 03:41:41 +0000 (+0900) Subject: fiptool: fix existence check of FIP input file for update command X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=40866aaf1c60b31d46b1b969598e3403a4d8a6c1;p=project%2Fbcm63xx%2Fatf.git fiptool: fix existence check of FIP input file for update command This line should check the existence of the input file, but it is actually checking the output file. When -o option is given to the "update" command, the outfile is unlikely to exist, then parse_fip() is skipped and an empty FIP file is output. This is wrong behavior. Signed-off-by: Masahiro Yamada --- diff --git a/tools/fiptool/fiptool.c b/tools/fiptool/fiptool.c index 6145e26d..d51d6ab9 100644 --- a/tools/fiptool/fiptool.c +++ b/tools/fiptool/fiptool.c @@ -882,7 +882,7 @@ static int update_cmd(int argc, char *argv[]) if (outfile[0] == '\0') snprintf(outfile, sizeof(outfile), "%s", argv[0]); - if (access(outfile, F_OK) == 0) + if (access(argv[0], F_OK) == 0) parse_fip(argv[0], &toc_header); if (pflag)