From: Axel Lin <axel.lin@ingics.com>
Date: Wed, 1 Apr 2015 00:45:33 +0000 (+0800)
Subject: phy: spear1340-miphy: Return proper error for spear1340_miphy_xlate
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=407ed8357464851cf12d68c4a969cd933f8dbcaf;p=openwrt%2Fstaging%2Fblogic.git

phy: spear1340-miphy: Return proper error for spear1340_miphy_xlate

The of_xlate callback should return ERR_PTR on error.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---

diff --git a/drivers/phy/phy-spear1340-miphy.c b/drivers/phy/phy-spear1340-miphy.c
index e42bc200275f..1a00c2817f34 100644
--- a/drivers/phy/phy-spear1340-miphy.c
+++ b/drivers/phy/phy-spear1340-miphy.c
@@ -229,14 +229,14 @@ static struct phy *spear1340_miphy_xlate(struct device *dev,
 
 	if (args->args_count < 1) {
 		dev_err(dev, "DT did not pass correct no of args\n");
-		return NULL;
+		return ERR_PTR(-ENODEV);
 	}
 
 	priv->mode = args->args[0];
 
 	if (priv->mode != SATA && priv->mode != PCIE) {
 		dev_err(dev, "DT did not pass correct phy mode\n");
-		return NULL;
+		return ERR_PTR(-ENODEV);
 	}
 
 	return priv->phy;