From: Fabio Estevam Date: Mon, 17 Feb 2014 22:05:57 +0000 (-0300) Subject: pata_imx: Propagate the real error code on platform_get_irq() failure X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=3ef9cc31ee39dea369e989de3f7f9e822cc8de62;p=openwrt%2Fstaging%2Fblogic.git pata_imx: Propagate the real error code on platform_get_irq() failure No need to return a 'fake' return value on platform_get_irq() failure. Just return the error code itself instead. Also, change the error condition to irq < 0, so that only negative values are treated as errors. Signed-off-by: Fabio Estevam Signed-off-by: Tejun Heo --- diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c index 50e2cf29721e..121c748314c3 100644 --- a/drivers/ata/pata_imx.c +++ b/drivers/ata/pata_imx.c @@ -100,8 +100,8 @@ static int pata_imx_probe(struct platform_device *pdev) int ret; irq = platform_get_irq(pdev, 0); - if (irq <= 0) - return -EINVAL; + if (irq < 0) + return irq; priv = devm_kzalloc(&pdev->dev, sizeof(struct pata_imx_priv), GFP_KERNEL);