From: Jo-Philipp Wich <jow@openwrt.org>
Date: Wed, 23 Feb 2011 22:58:58 +0000 (+0000)
Subject: Never write errors to stdout from ipkg-make-index.sh
X-Git-Tag: reboot~17477
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=3edf9c354421445cfe5a8a5cf99d1bfcf57bee94;p=openwrt%2Fstaging%2Fchunkeey.git

Never write errors to stdout from ipkg-make-index.sh

Since the output of ipkg-make-index.sh is unconditionally used to create
the Packages file, sending the errors into this file is unacceptable
(both because they are not shown to users and because they make an
invalid Packages file).

For incorrect invocation, write to stderr.
For errors from which, send to /dev/null with stdout.

Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>

SVN-Revision: 25677
---

diff --git a/scripts/ipkg-make-index.sh b/scripts/ipkg-make-index.sh
index c4c46f8882..8ae7eedc9a 100755
--- a/scripts/ipkg-make-index.sh
+++ b/scripts/ipkg-make-index.sh
@@ -4,11 +4,11 @@ set -e
 pkg_dir=$1
 
 if [ -z $pkg_dir ] || [ ! -d $pkg_dir ]; then
-	echo "Usage: ipkg-make-index <package_directory>"
+	echo "Usage: ipkg-make-index <package_directory>" >&2
 	exit 1
 fi
 
-which md5sum 2>&1 >/dev/null || alias md5sum=md5
+which md5sum >/dev/null 2>&1 || alias md5sum=md5
 
 for pkg in `find $pkg_dir -name '*.ipk' | sort`; do
 	echo "Generating index for package $pkg" >&2