From: Hans Dedecker <dedeckeh@gmail.com>
Date: Tue, 23 Apr 2019 13:07:52 +0000 (+0200)
Subject: ndp: fix syslog flooding (FS#2242)
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=3cd48765b74e498f06397f4b90b64cafe3a82dd1;p=project%2Fodhcpd.git

ndp: fix syslog flooding (FS#2242)

Only log a syslog error in case adding of a proxy neighbor fails as a delete
failure cannot be considered as a syslog error for all cases.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
---

diff --git a/src/ndp.c b/src/ndp.c
index 41b0064..64a6c1c 100644
--- a/src/ndp.c
+++ b/src/ndp.c
@@ -361,11 +361,12 @@ static void setup_addr_for_relaying(struct in6_addr *addr, struct interface *ifa
 		if (iface == c || c->ndp != MODE_RELAY)
 			continue;
 
-		if (netlink_setup_proxy_neigh(addr, c->ifindex, add))
-			syslog(LOG_ERR, "Failed to %s proxy neighbour entry %s on %s",
-				add ? "add" : "delete", ipbuf, c->name);
-		else
+		if (netlink_setup_proxy_neigh(addr, c->ifindex, add)) {
+			if (add)
+				syslog(LOG_ERR, "Failed to add proxy neighbour entry %s on %s",
+				       ipbuf, c->name);
+		} else
 			syslog(LOG_DEBUG, "%s proxy neighbour entry %s on %s",
-				add ? "Added" : "Deleted", ipbuf, c->name);
+			       add ? "Added" : "Deleted", ipbuf, c->name);
 	}
 }