From: Axel Lin <axel.lin@ingics.com>
Date: Fri, 14 Dec 2012 12:08:00 +0000 (+0000)
Subject: iio: dac: ad5686: Don't set error code to voltage_uv
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=359570ad3fcfcc3a3031b3a5e01bfb616233eca0;p=openwrt%2Fstaging%2Fblogic.git

iio: dac: ad5686: Don't set error code to voltage_uv

regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
index bc92ff9309c2..01eb1d0e4e41 100644
--- a/drivers/iio/dac/ad5686.c
+++ b/drivers/iio/dac/ad5686.c
@@ -332,7 +332,11 @@ static int __devinit ad5686_probe(struct spi_device *spi)
 		if (ret)
 			goto error_put_reg;
 
-		voltage_uv = regulator_get_voltage(st->reg);
+		ret = regulator_get_voltage(st->reg);
+		if (ret < 0)
+			goto error_disable_reg;
+
+		voltage_uv = ret;
 	}
 
 	st->chip_info =