From: Helmut Grohne Date: Mon, 4 Jun 2018 10:22:19 +0000 (+0200) Subject: serial: xuartps: remove unnecessary register write X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=34b6a3a91f87851bc0ea9e6776266f23d8acf388;p=openwrt%2Fstaging%2Fblogic.git serial: xuartps: remove unnecessary register write This writel writes the exact same value as the previous writel and is thus unnecessary. It accidentally became unnecessary in e3538c37ee38 ("tty: xuartps: Beautify read-modify writes"), but the new behaviour is now expected. Link: https://www.spinics.net/lists/linux-serial/msg23168.html Signed-off-by: Helmut Grohne Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 5f040cee595c..a48f19b1b88f 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1203,8 +1203,6 @@ static void cdns_uart_console_write(struct console *co, const char *s, CDNS_UART_SR_TXEMPTY) cpu_relax(); - writel(ctrl, port->membase + CDNS_UART_CR); - /* restore interrupt state */ writel(imr, port->membase + CDNS_UART_IER);