From: Adrian Schmutzler Date: Wed, 16 Sep 2020 14:29:21 +0000 (+0200) Subject: rtl838x: fix incorrect assignment from kstrtoul in serial.c X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=300173950da07e43b56d819114c1d1271ea213cc;p=openwrt%2Fstaging%2Fnbd.git rtl838x: fix incorrect assignment from kstrtoul in serial.c Assign return value of kstrtoul to error variable instead of conversion value. Suggested-by: Birger Koblitz Signed-off-by: Adrian Schmutzler --- diff --git a/target/linux/rtl838x/files-5.4/arch/mips/rtl838x/serial.c b/target/linux/rtl838x/files-5.4/arch/mips/rtl838x/serial.c index 8a85933baf..74a29c505e 100644 --- a/target/linux/rtl838x/files-5.4/arch/mips/rtl838x/serial.c +++ b/target/linux/rtl838x/files-5.4/arch/mips/rtl838x/serial.c @@ -54,7 +54,7 @@ int __init rtl838x_serial_init(void) s = strstr(arcs_cmdline, "console=ttyS0,"); if (s) { s += 14; - baud = kstrtoul(s, 10, &baud); + err = kstrtoul(s, 10, &baud); if (err) baud = 0; while (isdigit(*s))