From: perr perr Date: Tue, 16 Aug 2016 10:45:29 +0000 (+0800) Subject: pinctrl: exynos: remove duplicate calls in irq handler X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=26fecf0b21d17d17ba98fd64e8ac5a5c87ffb0d5;p=openwrt%2Fstaging%2Fblogic.git pinctrl: exynos: remove duplicate calls in irq handler Because chained_irq_enter() has already called chip->irq_mask() and chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), so it's not necessary to call chip->irq_*() here. Signed-off-by: Perr Zhang Acked-by: Tomasz Figa Reviewed-by: Krzysztof Kozlowski [Hand-edited from whitespace damaged patch] Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 051b5bf701a8..d32fa2b5ff82 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -428,14 +428,10 @@ static void exynos_irq_eint0_15(struct irq_desc *desc) int eint_irq; chained_irq_enter(chip, desc); - chip->irq_mask(&desc->irq_data); - - if (chip->irq_ack) - chip->irq_ack(&desc->irq_data); eint_irq = irq_linear_revmap(bank->irq_domain, eintd->irq); generic_handle_irq(eint_irq); - chip->irq_unmask(&desc->irq_data); + chained_irq_exit(chip, desc); }