From: Jens Axboe Date: Fri, 24 Nov 2017 17:12:33 +0000 (-0700) Subject: nvme-fc: don't use bit masks for set/test_bit() numbers X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=26c0a26d78bc7c2943d55121a32cb85a4594f8ea;p=openwrt%2Fstaging%2Fblogic.git nvme-fc: don't use bit masks for set/test_bit() numbers So far harmless, but it's confusing and a bug waiting to happen if the shifts grow larger than 4. Reviewed-by: Christoph Hellwig Signed-off-by: Jens Axboe --- diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index e0577bf33f45..0a8af4daef89 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -31,8 +31,8 @@ enum nvme_fc_queue_flags { - NVME_FC_Q_CONNECTED = (1 << 0), - NVME_FC_Q_LIVE = (1 << 1), + NVME_FC_Q_CONNECTED = 0, + NVME_FC_Q_LIVE, }; #define NVMEFC_QUEUE_DELAY 3 /* ms units */