From: Aybuke Ozdemir Date: Tue, 13 Oct 2015 20:55:07 +0000 (+0300) Subject: Staging: skein: Remove NULL comparison X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=26368fd7048f2c26d5263a932614351f04436be7;p=openwrt%2Fstaging%2Fblogic.git Staging: skein: Remove NULL comparison Problem found using checkpatch.pl CHECK: Comparison to NULL could be written "key" Signed-off-by: Aybuke Ozdemir Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/skein/skein_base.c b/drivers/staging/skein/skein_base.c index bfb08fa4045c..25a01ca76953 100644 --- a/drivers/staging/skein/skein_base.c +++ b/drivers/staging/skein/skein_base.c @@ -88,7 +88,7 @@ int skein_256_init_ext(struct skein_256_ctx *ctx, size_t hash_bit_len, } cfg; /* config block */ skein_assert_ret(hash_bit_len > 0, SKEIN_BAD_HASHLEN); - skein_assert_ret(key_bytes == 0 || key != NULL, SKEIN_FAIL); + skein_assert_ret(key_bytes == 0 || key, SKEIN_FAIL); /* compute the initial chaining values ctx->x[], based on key */ if (key_bytes == 0) { /* is there a key? */ @@ -316,7 +316,7 @@ int skein_512_init_ext(struct skein_512_ctx *ctx, size_t hash_bit_len, } cfg; /* config block */ skein_assert_ret(hash_bit_len > 0, SKEIN_BAD_HASHLEN); - skein_assert_ret(key_bytes == 0 || key != NULL, SKEIN_FAIL); + skein_assert_ret(key_bytes == 0 || key, SKEIN_FAIL); /* compute the initial chaining values ctx->x[], based on key */ if (key_bytes == 0) { /* is there a key? */ @@ -537,7 +537,7 @@ int skein_1024_init_ext(struct skein_1024_ctx *ctx, size_t hash_bit_len, } cfg; /* config block */ skein_assert_ret(hash_bit_len > 0, SKEIN_BAD_HASHLEN); - skein_assert_ret(key_bytes == 0 || key != NULL, SKEIN_FAIL); + skein_assert_ret(key_bytes == 0 || key, SKEIN_FAIL); /* compute the initial chaining values ctx->x[], based on key */ if (key_bytes == 0) { /* is there a key? */