From: Jarod Wilson Date: Tue, 17 Aug 2010 21:41:08 +0000 (-0400) Subject: Staging: lirc: fix compiler warning X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=211673991ec168c293791a94ad7aa31998907768;p=openwrt%2Fstaging%2Fblogic.git Staging: lirc: fix compiler warning On Fri, Aug 13, 2010 at 03:38:40PM +0200, Dan Carpenter wrote: > Speak of left over stuff, it's weird that I didn't notice this before > but gcc complains about an unitialized variable in > imon_incoming_packet(). > > drivers/staging/lirc/lirc_imon.c: In function ‘imon_incoming_packet’: > drivers/staging/lirc/lirc_imon.c:661: warning: ‘chunk_num’ may be used > uninitialized in this function > > I don't know how to fix that, but it looks important. Ew. Yeah, that doesn't look so hot like it is right now. The old lirc_imon driver had chunk_num = buf[7], and made much more extensive use of chunk_num. Simply removing chunk_num and using buf[7] should be fine. Signed-off-by: Jarod Wilson Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/lirc/lirc_imon.c b/drivers/staging/lirc/lirc_imon.c index cb5699c5b885..818bec0bb912 100644 --- a/drivers/staging/lirc/lirc_imon.c +++ b/drivers/staging/lirc/lirc_imon.c @@ -596,7 +596,7 @@ static void imon_incoming_packet(struct imon_context *context, struct device *dev = context->driver->dev; int octet, bit; unsigned char mask; - int i, chunk_num; + int i; /* * just bail out if no listening IR client @@ -655,7 +655,7 @@ static void imon_incoming_packet(struct imon_context *context, } } - if (chunk_num == 10) { + if (buf[7] == 10) { if (context->rx.count) { submit_data(context); context->rx.count = 0;