From: Arvind Yadav Date: Thu, 16 Nov 2017 04:27:26 +0000 (+0530) Subject: isdn: hisax: Fix pnp_irq's error checking for setup_ix1micro X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=203d2027a1e95e7d9585d734bdeaac6057058357;p=openwrt%2Fstaging%2Fblogic.git isdn: hisax: Fix pnp_irq's error checking for setup_ix1micro The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav Signed-off-by: David S. Miller --- diff --git a/drivers/isdn/hisax/ix1_micro.c b/drivers/isdn/hisax/ix1_micro.c index 7ae39f5e865d..bfb79f3f0a49 100644 --- a/drivers/isdn/hisax/ix1_micro.c +++ b/drivers/isdn/hisax/ix1_micro.c @@ -256,7 +256,7 @@ int setup_ix1micro(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "ITK PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d);