From: Dan Carpenter Date: Wed, 16 May 2012 20:51:02 +0000 (+0000) Subject: isdn: remove duplicate NULL check X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=1f352920b908247273a7c1937fd8c341cc1cedb1;p=openwrt%2Fstaging%2Fblogic.git isdn: remove duplicate NULL check We test both "!skb_out" and "skb_out" here which is duplicative and causes a static checker warning. I considered that the intent might have been to test "skb_in" but that's a valid pointer here. Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- diff --git a/drivers/isdn/i4l/isdn_bsdcomp.c b/drivers/isdn/i4l/isdn_bsdcomp.c index c59e8d2c0675..8837ac5a492d 100644 --- a/drivers/isdn/i4l/isdn_bsdcomp.c +++ b/drivers/isdn/i4l/isdn_bsdcomp.c @@ -612,7 +612,7 @@ static int bsd_compress(void *state, struct sk_buff *skb_in, struct sk_buff *skb db->n_bits++; /* If output length is too large then this is an incompressible frame. */ - if (!skb_out || (skb_out && skb_out->len >= skb_in->len)) { + if (!skb_out || skb_out->len >= skb_in->len) { ++db->incomp_count; db->incomp_bytes += isize; return 0;