From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 17 Nov 2014 12:35:54 +0000 (+0100)
Subject: ALSA: powermac: Deletion of an unnecessary check before the function call "pci_dev_put"
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=1ea7a568c63a4735872fc091efbd22d2e4d9c972;p=openwrt%2Fstaging%2Fblogic.git

ALSA: powermac: Deletion of an unnecessary check before the function call "pci_dev_put"

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c
index 8a431bcb056c..5a13b22748b2 100644
--- a/sound/ppc/pmac.c
+++ b/sound/ppc/pmac.c
@@ -887,8 +887,7 @@ static int snd_pmac_free(struct snd_pmac *chip)
 		}
 	}
 
-	if (chip->pdev)
-		pci_dev_put(chip->pdev);
+	pci_dev_put(chip->pdev);
 	of_node_put(chip->node);
 	kfree(chip);
 	return 0;