From: Viresh Kumar Date: Fri, 14 Nov 2014 11:55:03 +0000 (+0530) Subject: greybus: manifest: make sure manifest_descs list is empty before parsing manifest X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=1dd90df403692f718564638543e73b6d1f734f70;p=openwrt%2Fstaging%2Fblogic.git greybus: manifest: make sure manifest_descs list is empty before parsing manifest Just an extra check to make sure the list isn't corrupted. Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/manifest.c b/drivers/staging/greybus/manifest.c index d1357a2e64d7..4b85c5353978 100644 --- a/drivers/staging/greybus/manifest.c +++ b/drivers/staging/greybus/manifest.c @@ -332,6 +332,10 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size) u32 found = 0; bool result; + /* Manifest descriptor list should be empty here */ + if (WARN_ON(!list_empty(&manifest_descs))) + return false; + /* we have to have at _least_ the manifest header */ if (size <= sizeof(manifest->header)) { pr_err("short manifest (%zu)\n", size);