From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Thu, 17 Oct 2019 10:18:30 +0000 (+0200)
Subject: pid: use pid_has_task() in __change_pid()
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=1d416a113f0c0da7a3608ffe4d44bd8e9c4859fa;p=openwrt%2Fstaging%2Fblogic.git

pid: use pid_has_task() in __change_pid()

Replace hlist_empty() with the new pid_has_task() helper which is more
idiomatic, easier to grep for, and unifies how callers perform this
check.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20191017101832.5985-3-christian.brauner@ubuntu.com
---

diff --git a/kernel/pid.c b/kernel/pid.c
index 0a9f2e437217..124d40b239b1 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -299,7 +299,7 @@ static void __change_pid(struct task_struct *task, enum pid_type type,
 	*pid_ptr = new;
 
 	for (tmp = PIDTYPE_MAX; --tmp >= 0; )
-		if (!hlist_empty(&pid->tasks[tmp]))
+		if (pid_has_task(pid, tmp))
 			return;
 
 	free_pid(pid);