From: Uwe Kleine-König Date: Tue, 4 Dec 2018 08:31:30 +0000 (+0100) Subject: usb: chipidea: imx: Warn if oc polarity isn't specified X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=1bf4743f641d85f32fe3f3a4d8aa01a387549e3e;p=openwrt%2Fstaging%2Fblogic.git usb: chipidea: imx: Warn if oc polarity isn't specified The polarity of the over current detection pin isn't configured on i.MX6/7 if it's unspecified in the device tree. So the actual configuration depends on bootloader behavior which is bad. So encourage users to fix their device tree by issuing a warning in this case. Signed-off-by: Uwe Kleine-König Signed-off-by: Peter Chen --- diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 1951b37aa39d..e81de9ca8729 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -148,6 +148,8 @@ static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev) } else if (of_find_property(np, "over-current-active-low", NULL)) { data->oc_pol_active_low = 1; data->oc_pol_configured = 1; + } else { + dev_warn(dev, "No over current polarity defined\n"); } if (of_find_property(np, "external-vbus-divider", NULL))