From: Patrick Doyle <wpdster@gmail.com>
Date: Fri, 14 Jun 2019 17:43:38 +0000 (-0400)
Subject: rsa: reject images with unknown padding
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=19495dd9b6f5f4e893b56b0c73e14b2e671c3780;p=project%2Fbcm63xx%2Fu-boot.git

rsa: reject images with unknown padding

Previously we would store NULL in info->padding and jump to an illegal
instruction if an unknown value for "padding" was specified in the
device tree.

Signed-off-by: Patrick Doyle <pdoyle@irobot.com>
---

diff --git a/common/image-sig.c b/common/image-sig.c
index 4f6b4ec412..004fbc525b 100644
--- a/common/image-sig.c
+++ b/common/image-sig.c
@@ -211,7 +211,7 @@ static int fit_image_setup_verify(struct image_sign_info *info,
 	info->required_keynode = required_keynode;
 	printf("%s:%s", algo_name, info->keyname);
 
-	if (!info->checksum || !info->crypto) {
+	if (!info->checksum || !info->crypto || !info->padding) {
 		*err_msgp = "Unknown signature algorithm";
 		return -1;
 	}