From: Scott Wood Date: Thu, 12 Mar 2015 21:46:01 +0000 (-0500) Subject: usb: gadget: serial: %pf is only for function pointers X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=16d9efa4b3db0ab69605ff4d03d707d0210f4bf7;p=openwrt%2Fstaging%2Fblogic.git usb: gadget: serial: %pf is only for function pointers Use %ps for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pf expects a function descriptor (which is not what __builtin_return_address returns). Reviewed-by: Fabio Estevam Signed-off-by: Scott Wood Cc: linux-usb@vger.kernel.org CC: Sergei Shtylyov Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/function/u_serial.c index 491082aaf103..89179ab20c10 100644 --- a/drivers/usb/gadget/function/u_serial.c +++ b/drivers/usb/gadget/function/u_serial.c @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch) unsigned long flags; int status; - pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n", + pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n", port->port_num, tty, ch, __builtin_return_address(0)); spin_lock_irqsave(&port->port_lock, flags);