From: Gustavo A. R. Silva Date: Mon, 20 Feb 2017 23:28:46 +0000 (-0600) Subject: usb: misc: remove unnecessary code X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=144a3cbe12ecabc0c11f8a0f2c5d878fe4fa6392;p=openwrt%2Fstaging%2Fblogic.git usb: misc: remove unnecessary code 'val' is an unsigned variable, and less-than-zero comparison of an unsigned variable is never true. Addresses-Coverity-ID: 1230257 Signed-off-by: Gustavo A. R. Silva Reviewed-by: Peter Senna Tschudin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c index b7fc978724de..c731a75f28ee 100644 --- a/drivers/usb/misc/lvstest.c +++ b/drivers/usb/misc/lvstest.c @@ -193,7 +193,7 @@ static ssize_t u2_timeout_store(struct device *dev, return ret; } - if (val < 0 || val > 127) + if (val > 127) return -EINVAL; ret = lvs_rh_set_port_feature(hdev, lvs->portnum | (val << 8),