From: Axel Lin <axel.lin@ingics.com>
Date: Tue, 18 Dec 2012 03:33:00 +0000 (+0000)
Subject: iio: dac: ad5446: Don't set error code to voltage_uv
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=13e57ee2056221296f1926d49d00edd224058bea;p=openwrt%2Fstaging%2Fblogic.git

iio: dac: ad5446: Don't set error code to voltage_uv

regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
index 3310cbbd41e7..ecb639540dff 100644
--- a/drivers/iio/dac/ad5446.c
+++ b/drivers/iio/dac/ad5446.c
@@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,
 		if (ret)
 			goto error_put_reg;
 
-		voltage_uv = regulator_get_voltage(reg);
+		ret = regulator_get_voltage(reg);
+		if (ret < 0)
+			goto error_disable_reg;
+
+		voltage_uv = ret;
 	}
 
 	indio_dev = iio_device_alloc(sizeof(*st));