From: Alexander Couzens Date: Sun, 11 Jun 2017 10:51:58 +0000 (+0200) Subject: ar71xx/ag71xx_ethtool: don't return uninitialized return value on success X-Git-Tag: v19.07.0-rc1~6276 X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=10259416628da6f8098ec77be1b59c8f8951c8c4;p=openwrt%2Fstaging%2Fhauke.git ar71xx/ag71xx_ethtool: don't return uninitialized return value on success ag71xx_ethtool_set_ringparam() will return an uninitialized value on success. Found-by: Coverity Scan #1330877 Signed-off-by: Alexander Couzens --- diff --git a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ethtool.c b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ethtool.c index dfcbb54e93..f0e102152f 100644 --- a/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ethtool.c +++ b/target/linux/ar71xx/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ethtool.c @@ -86,7 +86,7 @@ static int ag71xx_ethtool_set_ringparam(struct net_device *dev, struct ag71xx *ag = netdev_priv(dev); unsigned tx_size; unsigned rx_size; - int err; + int err = 0; if (er->rx_mini_pending != 0|| er->rx_jumbo_pending != 0 ||