From: Konrad Rzeszutek Wilk Date: Tue, 22 Apr 2014 14:48:17 +0000 (-0400) Subject: xen/pciback: Document the entry points for 'pcistub_put_pci_dev' X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=0a9fd0152929db372ff61b0d6c280fdd34ae8bdb;p=openwrt%2Fstaging%2Fblogic.git xen/pciback: Document the entry points for 'pcistub_put_pci_dev' which are quite a few. It should be evident that dealing with that many options is a bit complex. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: David Vrabel --- diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c index 1539becad139..d57a173685f3 100644 --- a/drivers/xen/xen-pciback/pci_stub.c +++ b/drivers/xen/xen-pciback/pci_stub.c @@ -242,6 +242,15 @@ struct pci_dev *pcistub_get_pci_dev(struct xen_pcibk_device *pdev, return found_dev; } +/* + * Called when: + * - XenBus state has been reconfigure (pci unplug). See xen_pcibk_remove_device + * - XenBus state has been disconnected (guest shutdown). See xen_pcibk_xenbus_remove + * - 'echo BDF > unbind' on pciback module with no guest attached. See pcistub_remove + * - 'echo BDF > unbind' with a guest still using it. See pcistub_remove + * + * As such we have to be careful. + */ void pcistub_put_pci_dev(struct pci_dev *dev) { struct pcistub_device *psdev, *found_psdev = NULL;