From: Ezequiel Garcia Date: Tue, 14 May 2013 11:15:21 +0000 (-0300) Subject: mtd: nand: pxa3xx: Set info->use_dma properly X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=0a60d049812e959b43b0556ef5b914d0900b6283;p=openwrt%2Fstaging%2Fblogic.git mtd: nand: pxa3xx: Set info->use_dma properly Currently, the variable info->use_dma is never set and always zero-valued which means the driver never does DMA transfers. We fix this by simply setting info->use_dma to the module parameter, also named 'use_dma'. Note that the module parameter has the same name, but different semantics. This fixes a regression introduced by the below commit which removed the info->use_dma variable set. commit 4eb2da8994042d68e84e31138788429a102da2ea Author: Lei Wen Date: Mon Feb 28 10:32:13 2011 +0800 mtd: pxa3xx_nand: unify prepare command Before the above commit, the driver had use_dma=1 on all NAND commands except on CMD_STATUS. This behavior is long lost and we are not recovering in this patch, either. This was spotted and verified by human inspection. Signed-off-by: Ezequiel Garcia Tested-by: Nikita Kiryanov Acked-by: Igor Grinberg Reviewed-by: Haojian Zhuang Signed-off-by: Artem Bityutskiy Signed-off-by: David Woodhouse --- diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c index 14d3db518821..cef1eeb15d52 100644 --- a/drivers/mtd/nand/pxa3xx_nand.c +++ b/drivers/mtd/nand/pxa3xx_nand.c @@ -506,6 +506,7 @@ static int prepare_command_pool(struct pxa3xx_nand_info *info, int command, info->buf_count = 0; info->oob_size = 0; info->use_ecc = 0; + info->use_dma = (use_dma) ? 1 : 0; info->is_ready = 0; info->retcode = ERR_NONE; if (info->cs != 0)