From: Julia Lawall <julia@diku.dk>
Date: Fri, 28 Oct 2011 22:58:16 +0000 (-0300)
Subject: [media] drivers/media/video/atmel-isi.c: eliminate a null pointer dereference
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=0a4524d726cd4d109c57fc194a55ff0a9e4df0e9;p=openwrt%2Fstaging%2Fblogic.git

[media] drivers/media/video/atmel-isi.c: eliminate a null pointer dereference

The variable isi might be null or might be freed at the point of the call
to clk_put.  pclk contains the value that isi->pclk is expected to point to.

The semantic match that finds this problem is as follows:

// <smpl>
@r@
expression E, E1;
identifier f;
statement S1,S2,S3;
@@

if (E == NULL)
{
  ... when != if (E == NULL || ...) S1 else S2
      when != E = E1
*E->f
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/video/atmel-isi.c b/drivers/media/video/atmel-isi.c
index 8c775c59e120..fbc904f2f6fd 100644
--- a/drivers/media/video/atmel-isi.c
+++ b/drivers/media/video/atmel-isi.c
@@ -1036,7 +1036,7 @@ err_alloc_ctx:
 err_alloc_descriptors:
 	kfree(isi);
 err_alloc_isi:
-	clk_put(isi->pclk);
+	clk_put(pclk);
 
 	return ret;
 }