From: Li RongQing Date: Fri, 10 Jan 2020 01:04:37 +0000 (+0800) Subject: bpf: Return -EBADRQC for invalid map type in __bpf_tx_xdp_map X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=0a29275b6300f39f78a87f2038bbfe5bdbaeca47;p=openwrt%2Fstaging%2Fblogic.git bpf: Return -EBADRQC for invalid map type in __bpf_tx_xdp_map A negative value should be returned if map->map_type is invalid although that is impossible now, but if we run into such situation in future, then xdpbuff could be leaked. Daniel Borkmann suggested: -EBADRQC should be returned to stay consistent with generic XDP for the tracepoint output and not to be confused with -EOPNOTSUPP from other locations like dev_map_enqueue() when ndo_xdp_xmit is missing and such. Suggested-by: Daniel Borkmann Signed-off-by: Li RongQing Signed-off-by: Daniel Borkmann Link: https://lore.kernel.org/bpf/1578618277-18085-1-git-send-email-lirongqing@baidu.com --- diff --git a/net/core/filter.c b/net/core/filter.c index a702761ef369..d6f58dc4e1c4 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -3522,7 +3522,7 @@ static int __bpf_tx_xdp_map(struct net_device *dev_rx, void *fwd, case BPF_MAP_TYPE_XSKMAP: return __xsk_map_redirect(fwd, xdp); default: - break; + return -EBADRQC; } return 0; }