From: Ville Syrjälä Date: Tue, 4 Jun 2019 14:02:14 +0000 (+0300) Subject: drm/i915: Drop pointless WARN_ON X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=0502a1af95a1a5611493052da1a56403b3a5f6fe;p=openwrt%2Fstaging%2Fblogic.git drm/i915: Drop pointless WARN_ON intel_dp_link_down() is static and it's only called from the pre-ddi DP functions, so having a WARN_ON(HAS_DDI) in there is quite pointless. Remove it. Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20190604140214.9947-2-ville.syrjala@linux.intel.com Reviewed-by: Manasi Navare --- diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 98410fd2af85..3aef12041672 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -3995,9 +3995,6 @@ intel_dp_link_down(struct intel_encoder *encoder, enum port port = encoder->port; u32 DP = intel_dp->DP; - if (WARN_ON(HAS_DDI(dev_priv))) - return; - if (WARN_ON((I915_READ(intel_dp->output_reg) & DP_PORT_EN) == 0)) return;