From: INAGAKI Hiroshi Date: Wed, 30 Mar 2022 03:00:42 +0000 (+0900) Subject: realtek: fix use of uninitialized sds_mode X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=04cca345dfc8d0debbdad0bb1907003d3433cd8c;p=openwrt%2Fstaging%2Fnbd.git realtek: fix use of uninitialized sds_mode The initial state of sds_mode in rtl9300_force_sds_mode() is null and it will be configured in switch-case. So print message after it. Signed-off-by: INAGAKI Hiroshi [amend commit message] Signed-off-by: Sander Vanheule --- diff --git a/target/linux/realtek/files-5.10/drivers/net/phy/rtl83xx-phy.c b/target/linux/realtek/files-5.10/drivers/net/phy/rtl83xx-phy.c index 4175b95043..259458b1be 100644 --- a/target/linux/realtek/files-5.10/drivers/net/phy/rtl83xx-phy.c +++ b/target/linux/realtek/files-5.10/drivers/net/phy/rtl83xx-phy.c @@ -1697,7 +1697,6 @@ void rtl9300_force_sds_mode(int sds, phy_interface_t phy_if) u32 v, cr_0, cr_1, cr_2; u32 m_bit, l_bit; - pr_info("%s --------------------- serdes %d forcing to %x ...\n", __func__, sds, sds_mode); pr_info("%s: SDS: %d, mode %d\n", __func__, sds, phy_if); switch (phy_if) { case PHY_INTERFACE_MODE_SGMII: @@ -1740,7 +1739,7 @@ void rtl9300_force_sds_mode(int sds, phy_interface_t phy_if) return; } - pr_info("%s: SDS mode %x\n", __func__, sds_mode); + pr_info("%s --------------------- serdes %d forcing to %x ...\n", __func__, sds, sds_mode); // Power down SerDes rtl9300_sds_field_w(sds, 0x20, 0, 7, 6, 0x3); if (sds == 5) pr_info("%s after %x\n", __func__, rtl930x_read_sds_phy(sds, 0x20, 0));