From: Markus Elfring Date: Sat, 29 Nov 2014 15:23:20 +0000 (+0100) Subject: net-ipvlan: Deletion of an unnecessary check before the function call "free_percpu" X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=04901cea2192ae2ea5a65165ed3174187d19d5c8;p=openwrt%2Fstaging%2Fblogic.git net-ipvlan: Deletion of an unnecessary check before the function call "free_percpu" The free_percpu() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Mahesh Bandewar Signed-off-by: David S. Miller --- diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 96b71b0d78f6..feb185389a87 100644 --- a/drivers/net/ipvlan/ipvlan_main.c +++ b/drivers/net/ipvlan/ipvlan_main.c @@ -125,8 +125,7 @@ static void ipvlan_uninit(struct net_device *dev) struct ipvl_dev *ipvlan = netdev_priv(dev); struct ipvl_port *port = ipvlan->port; - if (ipvlan->pcpu_stats) - free_percpu(ipvlan->pcpu_stats); + free_percpu(ipvlan->pcpu_stats); port->count -= 1; if (!port->count)