From: Jan-Tarek Butt <tarek@ring0.de>
Date: Fri, 14 Oct 2016 18:32:22 +0000 (+0200)
Subject: busybox: prevent globbing, word splitting
X-Git-Tag: v17.01.0-rc1~1159
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=02d5f9477be31d2ca27d4e9f4d2d19f964c40c7c;p=openwrt%2Fopenwrt.git

busybox: prevent globbing, word splitting

Double quote to prevent globbing and word splitting.

Signed-off-by: Jan-Tarek Butt <tarek@ring0.de>
---

diff --git a/package/utils/busybox/files/cron b/package/utils/busybox/files/cron
index 19ecc43173..a201374276 100755
--- a/package/utils/busybox/files/cron
+++ b/package/utils/busybox/files/cron
@@ -14,7 +14,7 @@ validate_cron_section() {
 start_service () {
 	[ -z "$(ls /etc/crontabs/)" ] && return 1
 
-	loglevel=$(uci_get "system.@system[0].cronloglevel")
+	loglevel="$(uci_get "system.@system[0].cronloglevel")"
 
 	[ -z "${loglevel}" ] || {
 		/sbin/validate_data uinteger "${loglevel}" 2>/dev/null
@@ -28,7 +28,7 @@ start_service () {
 	ln -s /etc/crontabs /var/spool/cron/ 2>/dev/null
 
 	procd_open_instance
-	procd_set_param command "$PROG" -f -c /etc/crontabs -l ${loglevel:-5}
+	procd_set_param command "$PROG" -f -c /etc/crontabs -l "${loglevel:-5}"
 	procd_close_instance
 }