From: Daniel Golle Date: Thu, 12 Sep 2024 11:43:52 +0000 (+0200) Subject: Revert "system-linux: re-apply ethtool on phy attachment" X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=02aa43d82d587d87523231be5a5e0bf956435725;p=project%2Fnetifd.git Revert "system-linux: re-apply ethtool on phy attachment" This reverts commit 68c8a4f94cd3cfd654a52cbc8b57c5c9d99640dd. Matching on flags IFF_UP AND NOT IFF_LOWER_UP and then reapply ethtool settings freaks out some PHY drivers. While a better method is being worked on, revert the problematic solution. Signed-off-by: Daniel Golle --- diff --git a/system-linux.c b/system-linux.c index 58c7373..4463a2a 100644 --- a/system-linux.c +++ b/system-linux.c @@ -701,9 +701,6 @@ static int system_get_arp_accept(struct device *dev, char *buf, const size_t buf #define IFF_LOWER_UP 0x10000 #endif -static void -system_set_ethtool_settings(struct device *dev, struct device_settings *s); - static void system_device_update_state(struct device *dev, unsigned int flags, unsigned int ifindex) { @@ -714,9 +711,6 @@ system_device_update_state(struct device *dev, unsigned int flags, unsigned int device_set_present(dev, ifindex > 0); } device_set_link(dev, flags & IFF_LOWER_UP ? true : false); - - if ((flags & IFF_UP) && !(flags & IFF_LOWER_UP)) - system_set_ethtool_settings(dev, &dev->settings); } /* Evaluate netlink messages */