From: Daniel Golle <daniel@makrotopia.org>
Date: Sun, 14 Mar 2021 19:04:20 +0000 (+0000)
Subject: firmware-utils/ptgen: remove unused variable assignment
X-Git-Url: http://git.lede-project.org./?a=commitdiff_plain;h=00a326a7360e5e172962e65392e85308e847997e;p=openwrt%2Fstaging%2Fjow.git

firmware-utils/ptgen: remove unused variable assignment

Discovered by coverty:

 CID 1473630:  Code maintainability issues  (UNUSED_VALUE)

 Assigning value from "type_to_guid_and_name(type, &name)" to
 "part_guid" here, but that stored value is overwritten before it can
 be used.

Remove the now redundant assignment of part_guid which is also set
conditionally later on.

Fixes: 4a078bd135 ("firmware-utils/ptgen: fix partition guid and name")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---

diff --git a/tools/firmware-utils/src/ptgen.c b/tools/firmware-utils/src/ptgen.c
index 1eed21393d..d911b9d1f0 100644
--- a/tools/firmware-utils/src/ptgen.c
+++ b/tools/firmware-utils/src/ptgen.c
@@ -630,7 +630,6 @@ int main (int argc, char **argv)
 			break;
 		case 't':
 			type = (char)strtoul(optarg, NULL, 16);
-			part_guid = type_to_guid_and_name(type, &name);
 			break;
 		case 'a':
 			active = (int)strtoul(optarg, NULL, 0);