powerpc/mm: Fix reporting of kernel execute faults on the 8xx
authorChristophe Leroy <christophe.leroy@c-s.fr>
Wed, 28 Nov 2018 09:27:04 +0000 (09:27 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 21 Dec 2018 05:20:45 +0000 (16:20 +1100)
On the 8xx, no-execute is set via PPP bits in the PTE. Therefore
a no-exec fault generates DSISR_PROTFAULT error bits,
not DSISR_NOEXEC_OR_G.

This patch adds DSISR_PROTFAULT in the test mask.

Fixes: d3ca587404b3 ("powerpc/mm: Fix reporting of kernel execute faults")
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/mm/fault.c

index c866d9a710fec745658b5fc5c84d23afbd373775..056b750071bb59b591b7d64feead8fbb797692c1 100644 (file)
@@ -226,7 +226,9 @@ static int mm_fault_error(struct pt_regs *regs, unsigned long addr,
 static bool bad_kernel_fault(bool is_exec, unsigned long error_code,
                             unsigned long address)
 {
-       if (is_exec && (error_code & (DSISR_NOEXEC_OR_G | DSISR_KEYFAULT))) {
+       /* NX faults set DSISR_PROTFAULT on the 8xx, DSISR_NOEXEC_OR_G on others */
+       if (is_exec && (error_code & (DSISR_NOEXEC_OR_G | DSISR_KEYFAULT |
+                                     DSISR_PROTFAULT))) {
                printk_ratelimited(KERN_CRIT "kernel tried to execute"
                                   " exec-protected page (%lx) -"
                                   "exploit attempt? (uid: %d)\n",