[PATCH] uml: separate libc-dependent helper code
authorJeff Dike <jdike@addtoit.com>
Mon, 7 Nov 2005 08:58:51 +0000 (00:58 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 7 Nov 2005 15:53:31 +0000 (07:53 -0800)
The serial UML OS-abstraction layer patch (um/kernel dir).

This moves all systemcalls from helper.c file under os-Linux dir

Signed-off-by: Gennady Sharapov <Gennady.V.Sharapov@intel.com>
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
20 files changed:
arch/um/drivers/chan_user.c
arch/um/drivers/harddog_kern.c
arch/um/drivers/harddog_user.c
arch/um/drivers/net_user.c
arch/um/drivers/port_user.c
arch/um/drivers/slip_user.c
arch/um/drivers/slirp_user.c
arch/um/drivers/xterm.c
arch/um/include/helper.h [deleted file]
arch/um/include/os.h
arch/um/kernel/Makefile
arch/um/kernel/helper.c [deleted file]
arch/um/kernel/ksyms.c
arch/um/kernel/sigio_user.c
arch/um/kernel/user_util.c
arch/um/os-Linux/Makefile
arch/um/os-Linux/aio.c
arch/um/os-Linux/drivers/ethertap_user.c
arch/um/os-Linux/drivers/tuntap_user.c
arch/um/os-Linux/helper.c [new file with mode: 0644]

index de3bce71aeb3e8f3b3d283da35a77949a6444022..1c55d580248993c9ef1dd7249ccf8bb8e548c745 100644 (file)
@@ -16,7 +16,6 @@
 #include "user_util.h"
 #include "chan_user.h"
 #include "user.h"
-#include "helper.h"
 #include "os.h"
 #include "choose-mode.h"
 #include "mode.h"
index 147ec19f6bb9dc98c2dd026c25bd49cf9cc1a959..49acb2badf3229437c7a0149bc3da5be8d7d2109 100644 (file)
@@ -46,7 +46,6 @@
 #include <linux/smp_lock.h>
 #include <linux/init.h>
 #include <asm/uaccess.h>
-#include "helper.h"
 #include "mconsole.h"
 
 MODULE_LICENSE("GPL");
index d934181b8d4c67238b3fa10a5941952884743e1b..def013b5a3c7a5ec373dae711829b4ae10f76349 100644 (file)
@@ -8,7 +8,6 @@
 #include <errno.h>
 #include "user_util.h"
 #include "user.h"
-#include "helper.h"
 #include "mconsole.h"
 #include "os.h"
 #include "choose-mode.h"
index 3730d4f1271368e43ee147303973b8490ab153ea..098fa65981aba6404eb9422137466d39d5ffc38b 100644 (file)
@@ -16,7 +16,6 @@
 #include "user_util.h"
 #include "kern_util.h"
 #include "net_user.h"
-#include "helper.h"
 #include "os.h"
 
 int tap_open_common(void *dev, char *gate_addr)
index 14dd2002d2da6946bd61ac133198f112338cff31..ed4a1a6c5d83fa03fb515f69a2fc30340f596301 100644 (file)
@@ -18,7 +18,6 @@
 #include "user.h"
 #include "chan_user.h"
 #include "port.h"
-#include "helper.h"
 #include "os.h"
 
 struct port_chan {
index 71af444e591f8bff7b097ac57dc85376529fb677..89fbec185cc16ec10d2d8df49410cf8bb32080a1 100644 (file)
@@ -14,7 +14,6 @@
 #include "net_user.h"
 #include "slip.h"
 #include "slip_common.h"
-#include "helper.h"
 #include "os.h"
 
 void slip_user_init(void *data, void *dev)
index 8d91f663d82c684267567f2489f8059b738590e8..b94c66114bc85d7a56fe4d9f6d29d4d31a633c13 100644 (file)
@@ -13,7 +13,6 @@
 #include "net_user.h"
 #include "slirp.h"
 #include "slip_common.h"
-#include "helper.h"
 #include "os.h"
 
 void slirp_user_init(void *data, void *dev)
index 90e0e5ff451e1cc2f21909ff90b6a40575172baa..b530f1a6540d506a556e38c90dc3afec63f2f7f6 100644 (file)
@@ -14,7 +14,6 @@
 #include <sys/socket.h>
 #include "kern_util.h"
 #include "chan_user.h"
-#include "helper.h"
 #include "user_util.h"
 #include "user.h"
 #include "os.h"
diff --git a/arch/um/include/helper.h b/arch/um/include/helper.h
deleted file mode 100644 (file)
index 162ac31..0000000
+++ /dev/null
@@ -1,27 +0,0 @@
-/* 
- * Copyright (C) 2002 Jeff Dike (jdike@karaya.com)
- * Licensed under the GPL
- */
-
-#ifndef __HELPER_H__
-#define __HELPER_H__
-
-extern int run_helper(void (*pre_exec)(void *), void *pre_data, char **argv,
-                     unsigned long *stack_out);
-extern int run_helper_thread(int (*proc)(void *), void *arg, 
-                            unsigned int flags, unsigned long *stack_out,
-                            int stack_order);
-extern int helper_wait(int pid);
-
-#endif
-
-/*
- * Overrides for Emacs so that we follow Linus's tabbing style.
- * Emacs will notice this stuff at the end of the file and automatically
- * adjust the settings for this buffer only.  This must remain at the end
- * of the file.
- * ---------------------------------------------------------------------------
- * Local variables:
- * c-file-style: "linux"
- * End:
- */
index b9f53519bbe638e329629f3470ee30e3241ed151..112d7288f0cf816678cd3515f0b8923db0190e96 100644 (file)
@@ -205,6 +205,14 @@ extern unsigned long __do_user_copy(void *to, const void *from, int n,
                                    void (*op)(void *to, const void *from,
                                               int n), int *faulted_out);
 
+/* helper.c */
+extern int run_helper(void (*pre_exec)(void *), void *pre_data, char **argv,
+                     unsigned long *stack_out);
+extern int run_helper_thread(int (*proc)(void *), void *arg,
+                            unsigned int flags, unsigned long *stack_out,
+                            int stack_order);
+extern int helper_wait(int pid);
+
 #endif
 
 /*
index f9858583863a6eb9cbf11cca1145fee5f1fc1906..3de9d21e36bf042156b8b6c61cd8831c8885abea 100644 (file)
@@ -7,7 +7,7 @@ extra-y := vmlinux.lds
 clean-files :=
 
 obj-y = config.o exec_kern.o exitcode.o \
-       helper.o init_task.o irq.o irq_user.o ksyms.o mem.o physmem.o \
+       init_task.o irq.o irq_user.o ksyms.o mem.o physmem.o \
        process_kern.o ptrace.o reboot.o resource.o sigio_user.o sigio_kern.o \
        signal_kern.o signal_user.o smp.o syscall_kern.o sysrq.o time.o \
        time_kern.o tlb.o trap_kern.o trap_user.o uaccess.o um_arch.o \
@@ -24,8 +24,7 @@ obj-$(CONFIG_MODE_SKAS) += skas/
 
 user-objs-$(CONFIG_TTY_LOG) += tty_log.o
 
-USER_OBJS := $(user-objs-y) config.o helper.o time.o tty_log.o umid.o \
-       user_util.o
+USER_OBJS := $(user-objs-y) config.o time.o tty_log.o umid.o user_util.o
 
 include arch/um/scripts/Makefile.rules
 
diff --git a/arch/um/kernel/helper.c b/arch/um/kernel/helper.c
deleted file mode 100644 (file)
index 33fb0bd..0000000
+++ /dev/null
@@ -1,165 +0,0 @@
-/* 
- * Copyright (C) 2002 Jeff Dike (jdike@karaya.com)
- * Licensed under the GPL
- */
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <unistd.h>
-#include <errno.h>
-#include <sched.h>
-#include <sys/signal.h>
-#include <sys/wait.h>
-#include "user.h"
-#include "kern_util.h"
-#include "user_util.h"
-#include "helper.h"
-#include "os.h"
-
-struct helper_data {
-       void (*pre_exec)(void*);
-       void *pre_data;
-       char **argv;
-       int fd;
-};
-
-/* Debugging aid, changed only from gdb */
-int helper_pause = 0;
-
-static void helper_hup(int sig)
-{
-}
-
-static int helper_child(void *arg)
-{
-       struct helper_data *data = arg;
-       char **argv = data->argv;
-       int errval;
-
-       if(helper_pause){
-               signal(SIGHUP, helper_hup);
-               pause();
-       }
-       if(data->pre_exec != NULL)
-               (*data->pre_exec)(data->pre_data);
-       execvp(argv[0], argv);
-       errval = errno;
-       printk("execvp of '%s' failed - errno = %d\n", argv[0], errno);
-       os_write_file(data->fd, &errval, sizeof(errval));
-       os_kill_process(os_getpid(), 0);
-       return(0);
-}
-
-/* Returns either the pid of the child process we run or -E* on failure.
- * XXX The alloc_stack here breaks if this is called in the tracing thread */
-int run_helper(void (*pre_exec)(void *), void *pre_data, char **argv,
-              unsigned long *stack_out)
-{
-       struct helper_data data;
-       unsigned long stack, sp;
-       int pid, fds[2], ret, n;
-
-       if((stack_out != NULL) && (*stack_out != 0))
-               stack = *stack_out;
-       else stack = alloc_stack(0, um_in_interrupt());
-       if(stack == 0)
-               return(-ENOMEM);
-
-       ret = os_pipe(fds, 1, 0);
-       if(ret < 0){
-               printk("run_helper : pipe failed, ret = %d\n", -ret);
-               goto out_free;
-       }
-
-       ret = os_set_exec_close(fds[1], 1);
-       if(ret < 0){
-               printk("run_helper : setting FD_CLOEXEC failed, ret = %d\n",
-                      -ret);
-               goto out_close;
-       }
-
-       sp = stack + page_size() - sizeof(void *);
-       data.pre_exec = pre_exec;
-       data.pre_data = pre_data;
-       data.argv = argv;
-       data.fd = fds[1];
-       pid = clone(helper_child, (void *) sp, CLONE_VM | SIGCHLD, &data);
-       if(pid < 0){
-               ret = -errno;
-               printk("run_helper : clone failed, errno = %d\n", errno);
-               goto out_close;
-       }
-
-       os_close_file(fds[1]);
-       fds[1] = -1;
-
-       /*Read the errno value from the child.*/
-       n = os_read_file(fds[0], &ret, sizeof(ret));
-       if(n < 0){
-               printk("run_helper : read on pipe failed, ret = %d\n", -n);
-               ret = n;
-               os_kill_process(pid, 1);
-       }
-       else if(n != 0){
-               CATCH_EINTR(n = waitpid(pid, NULL, 0));
-               ret = -errno;
-       } else {
-               ret = pid;
-       }
-
-out_close:
-       if (fds[1] != -1)
-               os_close_file(fds[1]);
-       os_close_file(fds[0]);
-out_free:
-       if(stack_out == NULL)
-               free_stack(stack, 0);
-       else *stack_out = stack;
-       return(ret);
-}
-
-int run_helper_thread(int (*proc)(void *), void *arg, unsigned int flags, 
-                     unsigned long *stack_out, int stack_order)
-{
-       unsigned long stack, sp;
-       int pid, status, err;
-
-       stack = alloc_stack(stack_order, um_in_interrupt());
-       if(stack == 0) return(-ENOMEM);
-
-       sp = stack + (page_size() << stack_order) - sizeof(void *);
-       pid = clone(proc, (void *) sp, flags | SIGCHLD, arg);
-       if(pid < 0){
-               err = -errno;
-               printk("run_helper_thread : clone failed, errno = %d\n", 
-                      errno);
-               return err;
-       }
-       if(stack_out == NULL){
-               CATCH_EINTR(pid = waitpid(pid, &status, 0));
-               if(pid < 0){
-                       err = -errno;
-                       printk("run_helper_thread - wait failed, errno = %d\n",
-                              errno);
-                       pid = err;
-               }
-               if(!WIFEXITED(status) || (WEXITSTATUS(status) != 0))
-                       printk("run_helper_thread - thread returned status "
-                              "0x%x\n", status);
-               free_stack(stack, stack_order);
-       }
-       else *stack_out = stack;
-       return(pid);
-}
-
-int helper_wait(int pid)
-{
-       int ret;
-
-       CATCH_EINTR(ret = waitpid(pid, NULL, WNOHANG));
-       if(ret < 0){
-               ret = -errno;
-               printk("helper_wait : waitpid failed, errno = %d\n", errno);
-       }
-       return(ret);
-}
index a97a72e516aa6f6c6b7b4e6e0e4814b6e24f3a69..7713e7a6f476fcdf910a99565be74ccdb01828f5 100644 (file)
@@ -20,7 +20,6 @@
 #include "user_util.h"
 #include "mem_user.h"
 #include "os.h"
-#include "helper.h"
 
 EXPORT_SYMBOL(stop);
 EXPORT_SYMBOL(uml_physmem);
index a52751108aa125c3299926efdb8d8aad53496a72..3fbfd956bfe7a297e12d6994d273a49735d34340 100644 (file)
@@ -18,7 +18,6 @@
 #include "kern_util.h"
 #include "user_util.h"
 #include "sigio.h"
-#include "helper.h"
 #include "os.h"
 
 /* Changed during early boot */
index 41d17c71511c51cf01077d51d2c6637863892c59..4c231161f25717b2bcbfad0c31598a87488beab0 100644 (file)
@@ -27,7 +27,6 @@
 #include "user.h"
 #include "mem_user.h"
 #include "init.h"
-#include "helper.h"
 #include "ptrace_user.h"
 #include "uml-config.h"
 
index 0b761a08f0df973659bbb13b1fa20d1afd9aad27..b83ac8e21c354eb6f7a27b21599569c31157143b 100644 (file)
@@ -3,10 +3,11 @@
 # Licensed under the GPL
 #
 
-obj-y = aio.o elf_aux.o file.o main.o mem.o process.o signal.o start_up.o \
-       time.o tt.o tty.o uaccess.o user_syms.o drivers/ sys-$(SUBARCH)/
+obj-y = aio.o elf_aux.o file.o helper.o main.o mem.o process.o signal.o \
+       start_up.o time.o tt.o tty.o uaccess.o user_syms.o drivers/ \
+       sys-$(SUBARCH)/
 
-USER_OBJS := aio.o elf_aux.o file.o main.o mem.o process.o signal.o \
+USER_OBJS := aio.o elf_aux.o file.o helper.o main.o mem.o process.o signal.o \
        start_up.o time.o tt.o tty.o uaccess.o
 
 elf_aux.o: $(ARCH_DIR)/kernel-offsets.h
index 41cfb09442013325f7511949f8d6171e2bbac487..ffa759addd3c657e7292c07482d49d6dbc24bc38 100644 (file)
@@ -10,7 +10,6 @@
 #include <sched.h>
 #include <sys/syscall.h>
 #include "os.h"
-#include "helper.h"
 #include "aio.h"
 #include "init.h"
 #include "user.h"
index cd4d6544da715eef01010a61ea46ff127651f9af..901b85e8a1c65c4df84ae87018b3d55cefd45698 100644 (file)
@@ -19,7 +19,6 @@
 #include "user_util.h"
 #include "net_user.h"
 #include "etap.h"
-#include "helper.h"
 #include "os.h"
 
 #define MAX_PACKET ETH_MAX_PACKET
index 4ba9b17adf13cac85f62dfc224218bbeb9b354d7..52945338b64d503ea13c0d20ad4d45ba607e53f5 100644 (file)
@@ -20,7 +20,6 @@
 #include "kern_util.h"
 #include "user_util.h"
 #include "user.h"
-#include "helper.h"
 #include "os.h"
 
 #define MAX_PACKET ETH_MAX_PACKET
diff --git a/arch/um/os-Linux/helper.c b/arch/um/os-Linux/helper.c
new file mode 100644 (file)
index 0000000..36cc847
--- /dev/null
@@ -0,0 +1,165 @@
+/*
+ * Copyright (C) 2002 Jeff Dike (jdike@karaya.com)
+ * Licensed under the GPL
+ */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <unistd.h>
+#include <errno.h>
+#include <sched.h>
+#include <sys/signal.h>
+#include <sys/wait.h>
+#include "user.h"
+#include "kern_util.h"
+#include "user_util.h"
+#include "os.h"
+
+struct helper_data {
+       void (*pre_exec)(void*);
+       void *pre_data;
+       char **argv;
+       int fd;
+};
+
+/* Debugging aid, changed only from gdb */
+int helper_pause = 0;
+
+static void helper_hup(int sig)
+{
+}
+
+static int helper_child(void *arg)
+{
+       struct helper_data *data = arg;
+       char **argv = data->argv;
+       int errval;
+
+       if(helper_pause){
+               signal(SIGHUP, helper_hup);
+               pause();
+       }
+       if(data->pre_exec != NULL)
+               (*data->pre_exec)(data->pre_data);
+       execvp(argv[0], argv);
+       errval = errno;
+       printk("execvp of '%s' failed - errno = %d\n", argv[0], errno);
+       os_write_file(data->fd, &errval, sizeof(errval));
+       kill(os_getpid(), SIGKILL);
+       return(0);
+}
+
+/* Returns either the pid of the child process we run or -E* on failure.
+ * XXX The alloc_stack here breaks if this is called in the tracing thread */
+int run_helper(void (*pre_exec)(void *), void *pre_data, char **argv,
+              unsigned long *stack_out)
+{
+       struct helper_data data;
+       unsigned long stack, sp;
+       int pid, fds[2], ret, n;
+
+       if((stack_out != NULL) && (*stack_out != 0))
+               stack = *stack_out;
+       else stack = alloc_stack(0, um_in_interrupt());
+       if(stack == 0)
+               return(-ENOMEM);
+
+       ret = os_pipe(fds, 1, 0);
+       if(ret < 0){
+               printk("run_helper : pipe failed, ret = %d\n", -ret);
+               goto out_free;
+       }
+
+       ret = os_set_exec_close(fds[1], 1);
+       if(ret < 0){
+               printk("run_helper : setting FD_CLOEXEC failed, ret = %d\n",
+                      -ret);
+               goto out_close;
+       }
+
+       sp = stack + page_size() - sizeof(void *);
+       data.pre_exec = pre_exec;
+       data.pre_data = pre_data;
+       data.argv = argv;
+       data.fd = fds[1];
+       pid = clone(helper_child, (void *) sp, CLONE_VM | SIGCHLD, &data);
+       if(pid < 0){
+               ret = -errno;
+               printk("run_helper : clone failed, errno = %d\n", errno);
+               goto out_close;
+       }
+
+       close(fds[1]);
+       fds[1] = -1;
+
+       /*Read the errno value from the child.*/
+       n = os_read_file(fds[0], &ret, sizeof(ret));
+       if(n < 0){
+               printk("run_helper : read on pipe failed, ret = %d\n", -n);
+               ret = n;
+               kill(pid, SIGKILL);
+               CATCH_EINTR(waitpid(pid, NULL, 0));
+       }
+       else if(n != 0){
+               CATCH_EINTR(n = waitpid(pid, NULL, 0));
+               ret = -errno;
+       } else {
+               ret = pid;
+       }
+
+out_close:
+       if (fds[1] != -1)
+               close(fds[1]);
+       close(fds[0]);
+out_free:
+       if(stack_out == NULL)
+               free_stack(stack, 0);
+       else *stack_out = stack;
+       return(ret);
+}
+
+int run_helper_thread(int (*proc)(void *), void *arg, unsigned int flags,
+                     unsigned long *stack_out, int stack_order)
+{
+       unsigned long stack, sp;
+       int pid, status, err;
+
+       stack = alloc_stack(stack_order, um_in_interrupt());
+       if(stack == 0) return(-ENOMEM);
+
+       sp = stack + (page_size() << stack_order) - sizeof(void *);
+       pid = clone(proc, (void *) sp, flags | SIGCHLD, arg);
+       if(pid < 0){
+               err = -errno;
+               printk("run_helper_thread : clone failed, errno = %d\n",
+                      errno);
+               return err;
+       }
+       if(stack_out == NULL){
+               CATCH_EINTR(pid = waitpid(pid, &status, 0));
+               if(pid < 0){
+                       err = -errno;
+                       printk("run_helper_thread - wait failed, errno = %d\n",
+                              errno);
+                       pid = err;
+               }
+               if(!WIFEXITED(status) || (WEXITSTATUS(status) != 0))
+                       printk("run_helper_thread - thread returned status "
+                              "0x%x\n", status);
+               free_stack(stack, stack_order);
+       }
+       else *stack_out = stack;
+       return(pid);
+}
+
+int helper_wait(int pid)
+{
+       int ret;
+
+       CATCH_EINTR(ret = waitpid(pid, NULL, WNOHANG));
+       if(ret < 0){
+               ret = -errno;
+               printk("helper_wait : waitpid failed, errno = %d\n", errno);
+       }
+       return(ret);
+}