atl1e: checking the status of atl1e_write_phy_reg
authorKangjie Lu <kjlu@umn.edu>
Wed, 26 Dec 2018 04:23:19 +0000 (22:23 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 28 Dec 2018 00:23:12 +0000 (16:23 -0800)
atl1e_write_phy_reg() could fail. The fix issues an error message when
it fails.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/atheros/atl1e/atl1e_main.c

index 9dc6da039a6d90ac4137a70e94b2c3213c2a4741..3164aad29bcf879aa0841a912d6bbeaa757caad6 100644 (file)
@@ -473,7 +473,9 @@ static void atl1e_mdio_write(struct net_device *netdev, int phy_id,
 {
        struct atl1e_adapter *adapter = netdev_priv(netdev);
 
-       atl1e_write_phy_reg(&adapter->hw, reg_num & MDIO_REG_ADDR_MASK, val);
+       if (atl1e_write_phy_reg(&adapter->hw,
+                               reg_num & MDIO_REG_ADDR_MASK, val))
+               netdev_err(netdev, "write phy register failed\n");
 }
 
 static int atl1e_mii_ioctl(struct net_device *netdev,