drm/plane: Clarify our expectations for src/dst rectangles
authorMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Thu, 10 Oct 2019 11:19:13 +0000 (13:19 +0200)
committerMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Thu, 10 Oct 2019 13:49:34 +0000 (15:49 +0200)
The rectangles are usually clipped, but it can be useful to have
them unclipped, for example for cursor planes.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
[mlankhorst: Change cursor plane to hardware performing clipping. (Ville)
             Fix dst description that went missing.]
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191010112918.15724-1-maarten.lankhorst@linux.intel.com
include/drm/drm_plane.h

index 328773690851856eaae7c1188575a6598b93a566..3f396d94afe407abd1bb0690bcb06fc7ebeffa3a 100644 (file)
@@ -184,8 +184,26 @@ struct drm_plane_state {
         */
        struct drm_property_blob *fb_damage_clips;
 
-       /** @src: clipped source coordinates of the plane (in 16.16) */
-       /** @dst: clipped destination coordinates of the plane */
+       /**
+        * @src:
+        *
+        * source coordinates of the plane (in 16.16).
+        *
+        * When using drm_atomic_helper_check_plane_state(),
+        * the coordinates are clipped, but the driver may choose
+        * to use unclipped coordinates instead when the hardware
+        * performs the clipping automatically.
+        */
+       /**
+        * @dst:
+        *
+        * clipped destination coordinates of the plane.
+        *
+        * When using drm_atomic_helper_check_plane_state(),
+        * the coordinates are clipped, but the driver may choose
+        * to use unclipped coordinates instead when the hardware
+        * performs the clipping automatically.
+        */
        struct drm_rect src, dst;
 
        /**