fjes: Fix wrong netdevice feature flags
authorTaku Izumi <izumi.taku@jp.fujitsu.com>
Wed, 15 Mar 2017 04:47:50 +0000 (13:47 +0900)
committerDavid S. Miller <davem@davemloft.net>
Wed, 15 Mar 2017 19:43:23 +0000 (12:43 -0700)
This patch fixes netdev->features for Extended Socket network device.

Currently Extended Socket network device's netdev->feature claims
NETIF_F_HW_CSUM, however this is completely wrong. There's no feature
of checksum offloading.
That causes invalid TCP/UDP checksum and packet rejection when IP
forwarding from Extended Socket network device to other network device.

NETIF_F_HW_CSUM should be omitted.

Signed-off-by: Taku Izumi <izumi.taku@jp.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/fjes/fjes_main.c

index b75d9cdcfb0c415c7abeaa97cebeacbc917e1abd..c4b3c4b77a9c1b36e997033529f2de3cb091acb4 100644 (file)
@@ -1316,7 +1316,7 @@ static void fjes_netdev_setup(struct net_device *netdev)
        netdev->min_mtu = fjes_support_mtu[0];
        netdev->max_mtu = fjes_support_mtu[3];
        netdev->flags |= IFF_BROADCAST;
-       netdev->features |= NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_CTAG_FILTER;
+       netdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
 }
 
 static void fjes_irq_watch_task(struct work_struct *work)