perf/core: Reduce context switch overhead
authorleilei.lin <leilei.lin@alibaba-inc.com>
Wed, 9 Aug 2017 00:29:21 +0000 (08:29 +0800)
committerIngo Molnar <mingo@kernel.org>
Thu, 10 Aug 2017 10:08:40 +0000 (12:08 +0200)
Skip most of the PMU context switching overhead when ctx->nr_events is 0.

50% performance overhead was observed under an extreme testcase.

Signed-off-by: leilei.lin <leilei.lin@alibaba-inc.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: acme@kernel.org
Cc: alexander.shishkin@linux.intel.com
Cc: eranian@gmail.com
Cc: jolsa@redhat.com
Cc: linxiulei@gmail.com
Cc: yang_oliver@hotmail.com
Link: http://lkml.kernel.org/r/20170809002921.69813-1-leilei.lin@alibaba-inc.com
[ Rewrote the changelog. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/events/core.c

index ee20d4c546b5ebc0248c084e11c483e0ef800c6f..d704e23914bf0ac841ab630f770d241139a09f2a 100644 (file)
@@ -3211,6 +3211,13 @@ static void perf_event_context_sched_in(struct perf_event_context *ctx,
                return;
 
        perf_ctx_lock(cpuctx, ctx);
+       /*
+        * We must check ctx->nr_events while holding ctx->lock, such
+        * that we serialize against perf_install_in_context().
+        */
+       if (!ctx->nr_events)
+               goto unlock;
+
        perf_pmu_disable(ctx->pmu);
        /*
         * We want to keep the following priority order:
@@ -3224,6 +3231,8 @@ static void perf_event_context_sched_in(struct perf_event_context *ctx,
                cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE);
        perf_event_sched_in(cpuctx, ctx, task);
        perf_pmu_enable(ctx->pmu);
+
+unlock:
        perf_ctx_unlock(cpuctx, ctx);
 }