hwmon: (shtc1) fix shtc1 and shtw1 id mask
authorDan Robertson <dan@dlrobertson.com>
Thu, 5 Sep 2019 01:45:54 +0000 (01:45 +0000)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 10 Sep 2019 18:42:22 +0000 (11:42 -0700)
Fix an error in the bitmaskfor the shtc1 and shtw1 bitmask used to
retrieve the chip ID from the ID register. See section 5.7 of the shtw1
or shtc1 datasheet for details.

Fixes: 1a539d372edd9832444e7a3daa710c444c014dc9 ("hwmon: add support for Sensirion SHTC1 sensor")
Signed-off-by: Dan Robertson <dan@dlrobertson.com>
Link: https://lore.kernel.org/r/20190905014554.21658-3-dan@dlrobertson.com
[groeck: Reordered to be first in series and adjusted accordingly]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/shtc1.c

index 83fe08185ac7d9a9a1a92338277b742fa0547919..b267cf2a9817ba5d32b8cdfdbe3f1f1c2bb1a725 100644 (file)
@@ -28,7 +28,7 @@ static const unsigned char shtc1_cmd_read_id_reg[]           = { 0xef, 0xc8 };
 
 /* constants for reading the ID register */
 #define SHTC1_ID         0x07
-#define SHTC1_ID_REG_MASK 0x1f
+#define SHTC1_ID_REG_MASK 0x3f
 
 /* delays for non-blocking i2c commands, both in us */
 #define SHTC1_NONBLOCKING_WAIT_TIME_HPM  14400